Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Properly include message when handing SCIM errors #753

Merged
merged 2 commits into from
Sep 10, 2024
Merged

[Fix] Properly include message when handing SCIM errors #753

merged 2 commits into from
Sep 10, 2024
+13 −3

Conversation

mgyucht
Copy link
Contributor

@mgyucht mgyucht commented Sep 10, 2024 •
edited
Loading

Changes

#741 introduced a regression in retrieving error details from SCIM APIs. This PR addresses this and adds a regression test for this case. The implementation should now match the Go SDK's here: https://github.com/databricks/databricks-sdk-go/blob/main/apierr/errors.go#L220-L224.

Fixes #749.

Tests

Added a unit test based on the supplied response in the ticket.

  • make test run locally
  • make fmt applied
  • relevant integration tests applied

@mgyucht mgyucht mentioned this pull request Sep 10, 2024
Closed
@mgyucht mgyucht added this pull request to the merge queue Sep 10, 2024
Merged via the queue into main with commit dcd06c0 Sep 10, 2024
14 checks passed
@mgyucht mgyucht deleted the issue-749 branch September 10, 2024 11:30
hectorcast-db added a commit that referenced this pull request Sep 10, 2024
@hectorcast-db
[Release] Release v0.32.1
cc288c9 
### Bug Fixes

 * Properly include message when handing SCIM errors ([#753](#753)).
@hectorcast-db hectorcast-db mentioned this pull request Sep 10, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Sep 10, 2024
@hectorcast-db
[Release] Release v0.32.1 (#754)
b34f502 
### Bug Fixes

* Properly include message when handing SCIM errors
([#753](#753)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hectorcast-db hectorcast-db hectorcast-db approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ISSUE] Regression in NotFound error message handling
2 participants
@mgyucht @hectorcast-db